Skip to content

Add ok-to-test label to self-upgrade PRs - #381

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:self-upgrade-labels
Aug 31, 2025
Merged

Add ok-to-test label to self-upgrade PRs#381
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:self-upgrade-labels

Conversation

@erikgb

@erikgb erikgb commented Aug 31, 2025

Copy link
Copy Markdown
Member

Now that we use a token from Octo STS, this is required to trigger workflows. Example: cert-manager/webhook-cert-lib#63

I see no harm in merging this to the main branch, even if we decide to not move forward with Octo STS.

/cherry-pick octo-sts-poc
/cc @ThatsMrTalbot

@erikgb
Add ok-to-test label to self-upgrade PRs
d84fbd0 
Signed-off-by: Erik Godding Boye
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2025
@ThatsMrTalbot

ThatsMrTalbot commented Aug 31, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2025
@cert-manager-prow

cert-manager-prow Bot commented Aug 31, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2025
@cert-manager-prow
cert-manager-prow Bot merged commit 5afd6eb into cert-manager:main Aug 31, 2025
4 checks passed
@cert-manager-bot

cert-manager-bot commented Aug 31, 2025

Copy link
Copy Markdown
Contributor

@erikgb: new pull request created: #382

Details

In response to this:

Now that we use a token from Octo STS, this is required to trigger workflows. Example: cert-manager/webhook-cert-lib#63

I see no harm in merging this to the main branch, even if we decide to not move forward with Octo STS.

/cherry-pick octo-sts-poc
/cc @ThatsMrTalbot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-bot cert-manager-bot mentioned this pull request Aug 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThatsMrTalbot ThatsMrTalbot Awaiting requested review from ThatsMrTalbot

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikgb @ThatsMrTalbot @cert-manager-bot